search

palra / univ-mmorpg

0 stars 0 forks source link

Exceptions #26

Closed drattak closed 9 years ago

drattak commented 9 years ago

https://github.com/palra/univ-mmorpg/blob/develop/src/main/java/fr/univdevs/mmorpg/bridge/FightCommand.java#L22-L38

This throws CommandException, what if I need to throw an InvalidArgumentException ?

drattak commented 9 years ago

else return "Vous avez entré une arme invalide"; ?

palra commented 9 years ago

Instead, throw an ArgumentValidationCommandException

palra commented 9 years ago

FYI, there is some exceptions already defined for some known cases : https://github.com/palra/univ-mmorpg/tree/develop/src/main/java/fr/univdevs/commander