search

paltalabs / create-soroban-dapp

Boilerplate for Soroban dApps in ReactJS
https://create-soroban-dapp.vercel.app
Apache License 2.0
7 stars 13 forks source link

Handle missing contract #17

Closed chopan123 closed 22 hours ago

chopan123 commented 2 weeks ago

ODHack

This issue is part of ODHack:

Description

Make a warning when there is no contract deployed. Currently it just saying that there was an error while searching the contract, not specifying that the contract is missing.

Expected Behaviour

When in standalone, there will not be a contract deployed, then it should say that we need to deploy a contract first.

Gift-Naomi commented 2 weeks ago

@chopan123 can I be assigned this issue? I’m a Web3 developer I have the experience , I can tackle this issue Here is a my onlydust profile https://app.onlydust.com/contributions?tab=COMPLETED

Vaibhav0-1 commented 2 weeks ago

Hey @chopan123 Can you assign this issue to me as I've mentioned the changes needed to resolve this issue,

Issue Resolution Proposal

Changes Proposed: Update isContractDeployed to return false in standalone mode when checking for deployed contracts. Modify contractTxWithToast to display a specific toast error when no contract is deployed in standalone mode.

Implementation Plan: Adjust isContractDeployed to recognize standalone mode and return false appropriately. Enhance contractTxWithToast to trigger a toast error message when attempting transactions without a deployed contract in standalone mode.

Next Steps: Implement proposed changes in isContractDeployed and contractTxWithToast. Test thoroughly to confirm the effectiveness of new contract deployment warnings.

fishseabowl commented 1 week ago

Could I take this? Thanks