paltalabs / create-soroban-dapp

Boilerplate for Soroban dApps in ReactJS
https://create-soroban-dapp.vercel.app
Apache License 2.0
7 stars 13 forks source link

`airdropAccount` should also support standalone #21

Open chopan123 opened 2 weeks ago

chopan123 commented 2 weeks ago

ODHack

This issue is part of ODHack:

Description

airdropAccount function should receive a network parameter to support standalone network. When no network is passed, it should use testnet as default.

No-bodyq commented 2 weeks ago

Is this open for contribution rn?? If so can I get assigned?? As the description suggests I will modify the function to accept a network parameter whilst keeping the default as testnet in the case no network is selected whilst ensuring appropriate corroboration of said parameter

Josh-121 commented 2 weeks ago

Hello, I have a software engineering background but new here and looking to make my first contribution. I can tackle this within today if assigned

GreatJeremy commented 2 weeks ago

Hello, I recently got introduced to OnlyDust at muAccra and I would love to contribute to this project if given the opportunity.

HumbertoTM10 commented 2 weeks ago

Hi @chopan123, is this still available to work on it?

jedstroke commented 2 weeks ago

GM @chopan123, here's my portfolio: https://www.jedshock.com. I hope I am deemed fit enough to tackle on this issue?

bitfalt commented 2 weeks ago

Hi! My name is Daniel and I'm a Computer Science student. This is my first ODHack and I would love to contribute to this project and tackle the issue.

I would solve this issue in the following way:

  1. Read and understand the code of the function airdropAcount
  2. Implement the network parameter
  3. Make the validation that if none is passed, it default to the testnet
  4. Additionally, test the implementation to ensure the behavior is the expected one.

If I have any questions regarding the code, I would ask one of the project leads for guidance.

bitfalt commented 1 week ago

I have my approach planned already, however I would like some feedback from @chopan123

Approach

This would be the approach that I thought of and would be taking. Any feedback or question regarding my approach is well apreciated!