Open chopan123 opened 2 weeks ago
Is this open for contribution rn??
If so can I get assigned??
As the description suggests I will modify the function to accept a network
parameter whilst keeping the default as testnet in the case no network is selected whilst ensuring appropriate corroboration of said parameter
Hello, I have a software engineering background but new here and looking to make my first contribution. I can tackle this within today if assigned
Hello, I recently got introduced to OnlyDust at muAccra and I would love to contribute to this project if given the opportunity.
Hi @chopan123, is this still available to work on it?
GM @chopan123, here's my portfolio: https://www.jedshock.com. I hope I am deemed fit enough to tackle on this issue?
Hi! My name is Daniel and I'm a Computer Science student. This is my first ODHack and I would love to contribute to this project and tackle the issue.
I would solve this issue in the following way:
airdropAcount
testnet
If I have any questions regarding the code, I would ask one of the project leads for guidance.
I have my approach planned already, however I would like some feedback from @chopan123
Env.Config.loadFromFile
is locate in soroban-react-dapp/contracts/util/env.config.ts
(Also while looking in soroban-react-dapp/contracts/util/contract.ts
the import of config
is defined as env.config.js
, probably this doesn't matter, but just pointing it out).loadFromFile
receives a string which is the network parameter, so I assume the new behaviour of airdropAccount
would be the following
string
or undefined
network_param == standalone
, if it is we would run conf = config(network_param)
otherwise conf = config(testnet)
(have in mind that wouldn't be the name of the variable nor the parameter, these are placeholders for the explanation). I was wondering what would be the difference between testnet
and testnet-public
, since in the configs.json
file they are defined the same.await conf.rpc.requestAidrop(…, conf.friendbot)
This would be the approach that I thought of and would be taking. Any feedback or question regarding my approach is well apreciated!
ODHack
This issue is part of ODHack:
Description
airdropAccount
function should receive anetwork
parameter to support standalone network. When no network is passed, it should usetestnet
as default.