Closed armandocodecr closed 22 hours ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
create-soroban-dapp | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 3, 2024 8:27pm |
create-soroban-dapp-docs | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 3, 2024 8:27pm |
Hello @chopan123 ! Any review on this PR?
you only modified 1 line in 1 file, there is more...
Yes, sorry, I didn't realize that the import was missing in the "env_config.ts" file. Is there any other file missing? I just checked and it doesn't seem to be missing any other than the one I just mentioned, but I'm still asking just to be sure.
Pull Request Description: Update to @stellar/stellar-sdk
Objective of the PR
This pull request aims to update the imports from the
stellar-sdk
library to@stellar/stellar-sdk
. The new@stellar/stellar-sdk
library is the updated and maintained version by Stellar, which includes the latest improvements, bug fixes, and compatibility with new features of the Stellar protocol.Changes Made
Replacement of the Library
stellar-sdk
was replaced with@stellar/stellar-sdk
in all project imports.Comprehensive Code Review
stellar-sdk
was reviewed to ensure compatibility with@stellar/stellar-sdk
.Testing and Validation
@stellar/stellar-sdk
.Justification and Benefits
@stellar/stellar-sdk
is the recommended and maintained version of the Stellar SDK, ensuring better support and future updates.Conclusion
Switching to
@stellar/stellar-sdk
ensures that the project stays aligned with current best practices and is prepared to leverage improvements in the Stellar ecosystem. This PR has been carefully reviewed and tested, ensuring that the transition does not affect the existing functionality of the application.We request a review of this PR to validate the changes made and confirm that there are no negative impacts on the application's functionality. We appreciate any feedback you can provide.