paltalabs / create-soroban-dapp

Boilerplate for Soroban dApps in ReactJS
https://create-soroban-dapp.vercel.app
Apache License 2.0
7 stars 13 forks source link

Issue #15 | Update stellar-sdk package #22

Closed armandocodecr closed 22 hours ago

armandocodecr commented 1 week ago

Pull Request Description: Update to @stellar/stellar-sdk

Objective of the PR

This pull request aims to update the imports from the stellar-sdk library to @stellar/stellar-sdk. The new @stellar/stellar-sdk library is the updated and maintained version by Stellar, which includes the latest improvements, bug fixes, and compatibility with new features of the Stellar protocol.

Changes Made

Replacement of the Library

Comprehensive Code Review

Testing and Validation

Justification and Benefits

Conclusion

Switching to @stellar/stellar-sdk ensures that the project stays aligned with current best practices and is prepared to leverage improvements in the Stellar ecosystem. This PR has been carefully reviewed and tested, ensuring that the transition does not affect the existing functionality of the application.

We request a review of this PR to validate the changes made and confirm that there are no negative impacts on the application's functionality. We appreciate any feedback you can provide.

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-soroban-dapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 8:27pm
create-soroban-dapp-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 8:27pm
armandocodecr commented 1 week ago

Hello @chopan123 ! Any review on this PR?

chopan123 commented 22 hours ago

you only modified 1 line in 1 file, there is more...

armandocodecr commented 22 hours ago

Yes, sorry, I didn't realize that the import was missing in the "env_config.ts" file. Is there any other file missing? I just checked and it doesn't seem to be missing any other than the one I just mentioned, but I'm still asking just to be sure.