search

paltalabs / soroban-react

@soroban-react is a simple, powerful framework for building modern Soroban dApps using React.
https://soroban-react.paltalabs.io/
Apache License 2.0
26 stars 13 forks source link

If the wallet does not provide a SorobanRpcUrl we should handle the error #51

Open esteblock opened 8 months ago

esteblock commented 8 months ago

Currently, if the user does not have correcly set his network, and does not provide a SorobanRpcUrl, the user cannot sign the tx and does not know what is happening. We should handle this error and pass the error to the frontend so the frontend shows a message to the user

benjaminsalon commented 8 months ago

This PR #52 is throwing an error if the soroban rpc url is not set. The error still needs to be handled in the frontend for better ui

esteblock commented 8 months ago

@benjaminsalon please make that the boilerplate handles this error and then help us in soroswap to handle it the same way: https://github.com/soroswap/frontend/issues/131

benjaminsalon commented 8 months ago

Ok @esteblock !