Revert "Button hiding logic and new UI for bottom docking"

[Joseph-Garvey]

Reverts palvarezc/cavendish-particle-tracks#131 due to issue where pop up windows do not display.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Flag	Coverage Δ
	89.16% <100.00%> (-0.94%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/cavendish_particle_tracks/_main_widget.py	91.76% <100.00%> (-1.50%)	:arrow_down:

[palvarezc]

@Joseph-Garvey , can you explain a bit more what the problem is. I just pulled main and everything seems ok.

[Joseph-Garvey]

Maybe the issue is only on windows? I click the magnification, stereoshift or decay angles button and no pop up window appears.

[palvarezc]

Maybe the issue is only on windows? I click the magnification, stereoshift or decay angles button and no pop up window appears.

Weird, working for me on macOS... let's see if @samcunliffe can reproduce?

Did you try opening napari in the button_logic branch?

[Joseph-Garvey]

in main:

https://github.com/user-attachments/assets/9ad250ce-a462-4ae5-a431-72862fcf747f

[Joseph-Garvey]

and in button_logic

https://github.com/user-attachments/assets/5ad1f08d-cd98-4733-87b3-fb51cb6239e2

[samcunliffe]

Maybe the issue is only on windows? I click the magnification, stereoshift or decay angles button and no pop up window appears.

Weird, working for me on macOS... let's see if @samcunliffe can reproduce?

I don't have any data other than the two example tiffs in tests/data. So I can no longer test anything in landscape mode.

The ascii art looks quite bad though...

In portrait mode, the dialogs open fine.

[samcunliffe]

... probably the right thing to do here is add a test. We will presumably see it fail on Windows but not others?

[palvarezc]

I just checked in Windows in the lab machine and I don't see the same issue.... Dialogs seem to open fine.

Although I also dont have any valid data, so had to turn bypass_load_screen=True in launch_debut.py

[palvarezc]

Created some test data, but found a different problem on loading:

 UnknownFormatError: Could not detect your file type because it did not have an extension. Try specifying a loader class, e.g. Video(C:/Users/pa459/Documents/data\VIEW1\/*)

which is strange as this is what the tests do, and the tests pass in this machine. Something going on between \ and /? But for @Joseph-Garvey this has been working on Windows all along.... I am a bit puzzled.

Edit: This error appears when there is only one image in each view folder. The way we import the data with dask_image requires more than one. Should add a warning of some kind!

[Joseph-Garvey]

@samcunliffe

I don't have any data other than the two example tiffs in tests/data. So I can no longer test anything in landscape mode.

If you look at PR #112 there's a file called testdims. It generates fake data to make development easier, worth using it on your instance maybe?

[Joseph-Garvey]

Created some test data, but found a different problem on loading:

 UnknownFormatError: Could not detect your file type because it did not have an extension. Try specifying a loader class, e.g. Video(C:/Users/pa459/Documents/data\VIEW1\/*)

which is strange as this is what the tests do, and the tests pass in this machine. Something going on between \ and /? But for @Joseph-Garvey this has been working on Windows all along.... I am a bit puzzled.

I have no issues using the real data or fake data generated by testdims.py. Although testdims isn't using the load data functions, it's just creating layers that have 4 dimensions to get past the intro screen.

[palvarezc]

... probably the right thing to do here is add a test. We will presumably see it fail on Windows but not others?

I think probably our tests already would fail if the dialogs would not show, but added a new one just in case:

• 150

[Joseph-Garvey]

Have tried wiping and reinstalling the plugin. It doesn't seem to help. Are you all using napari 0.5.2?

[palvarezc]

Have tried wiping and reinstalling the plugin. It doesn't seem to help. Are you all using napari 0.5.2?

I am in 0.5.3. Can you try whether the test in #150 fails for you?

[Joseph-Garvey]

Updating to napari 0.5.3 does not resolve the issue.

[Joseph-Garvey]

Tests pass, except for test_version_fallback...

[Joseph-Garvey]

Resetting venv to see if it resolves the issue. The fact we can't reproduce it is making this hard to trace. Are we using different versions of Qt?

Output of my napari --info: napari: 0.5.3 Platform: Windows-10-10.0.19045-SP0 Python: 3.12.6 | packaged by conda-forge | (main, Sep 22 2024, 14:01:26) [MSC v.1941 64 bit (AMD64)] Qt: 5.15.2 PyQt5: 5.15.11 NumPy: 2.0.2 SciPy: 1.14.1 Dask: 2024.9.0 VisPy: 0.14.3 magicgui: 0.9.1 superqt: 0.6.7 in-n-out: 0.2.1 app-model: 0.2.8 npe2: 0.7.7

OpenGL:

• GL version: 4.6.14761 Compatibility Profile Context 21.30.02.01 30.0.13002.1001
• MAX_TEXTURE_SIZE: 16384
• GL_MAX_3D_TEXTURE_SIZE: 2048

Screens:

• screen 1: resolution 1920x1080, scale 1.0

Optional:

• numba: 0.60.0
• triangle: 20230923
• napari-plugin-manager: 0.1.1

Settings path:

• C:\Users\josep\AppData\Local\napari\new_napari_env_5afd05a76e9adcb9f8aefff00630128a2ff88dcb\settings.yaml Plugins:
• cavendish-particle-tracks: 0.1.0b2.dev68+g9b38a91 (2 contributions)
• napari: 0.5.3 (81 contributions)
• napari-console: 0.0.9 (0 contributions)
• napari-svg: 0.2.0 (2 contributions)

[Joseph-Garvey]

Looks identical to the config from the lab pcs.

[samcunliffe]

@palvarezc you've tested on the lab computers, right? So I think we can close here.

(We can always reopen)