search

pamelafox / font-previewer-extension

Google Font Previewer Chrome Extension
https://chrome.google.com/webstore/detail/engndlnldodigdjamndkplafgmkkencc
69 stars 14 forks source link

Port to manifest v3 #17

Closed jerboa88 closed 2 years ago

jerboa88 commented 2 years ago

Implemented #15. This probably needs more testing but it seems to work fine for the most part.

I'll have to make make another issue for the reset button not working because I fixed the CSP issues and realized it is not restoring the original fonts.

pamelafox commented 2 years ago

Amazing, thanks for taking it on! I was worried wed need to do something more drastic like ship the fonts with the extension. I’ll review both PRs on monday.

On Sat, Jun 25, 2022 at 5:47 PM John Goodliff @.***> wrote:

Implemented #15 https://github.com/pamelafox/font-previewer-extension/issues/15. This probably needs more testing but it seems to work fine for the most part.

I'll have to make make another issue for the reset button not working because I fixed the CSP issues and realized it is not restoring the original fonts.

You can view, comment on, or merge this pull request online at:

https://github.com/pamelafox/font-previewer-extension/pull/17 Commit Summary

File Changes

(5 files https://github.com/pamelafox/font-previewer-extension/pull/17/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/pamelafox/font-previewer-extension/pull/17, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACIQUUR4AQW2VAVXVVBIMLVQ6SD3ANCNFSM5Z3C5WMQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

jerboa88 commented 2 years ago

Amazing, thanks for taking it on! I was worried wed need to do something more drastic like ship the fonts with the extension. I’ll review both PRs on monday.

For sure and no rush! I looked it up and the entire Google Font archive is around 600MB so shipping fonts with the extension probably isn't even feasible.

pamelafox commented 2 years ago

I made some updates and have updated the extension on the Chrome store. The new version should be live once it's approved. Can you merge with master? This PR currently has conflicts due to the changes.

jerboa88 commented 2 years ago

I've fixed the merge conflicts but I still need to:

jerboa88 commented 2 years ago

Commented out that event listener and fixed another issue. Everything seems to work fine now as far as I can tell. I'll let you take care of bumping the version and updating the dist before release.

pamelafox commented 2 years ago

Looks good, merging!