search

pamelarussell / TCIApathfinder

R client for The Cancer Imaging Archive REST API
Other
9 stars 5 forks source link

Added download and extraction code #3

Closed muschellij2 closed 5 years ago

muschellij2 commented 5 years ago

Fixes #2. Added save_extracted_image_series and extract_image_series and have pass through for out_dir.

muschellij2 commented 5 years ago

I've also added description and readme changes: https://travis-ci.com/muschellij2/TCIApathfinder/builds

You can sign up with GitHub at https://travis-ci.com for automatic checking of the package.

pamelarussell commented 5 years ago

Thank you! Could you just make a few minor edits:

muschellij2 commented 5 years ago

.Rbuildignore should be there for ignoring files while building for CRAN such as cran-comments.md TCIApathfinder.Rproj is for using RStudio to build the repo. I can delete - but won't hurt build process. .gitignore specifies which files you may have on your computer, but are not necessary for GitHub, such as README_cache/, when you had cache = TRUE for the readME.

Didn't have a test, but will add save_extracted_image_series as I put it in the vignettes

pamelarussell commented 5 years ago

Thanks for the test and updating DESCRIPTION and NEWS. I have my own local .gitignore and.Rbuildignore that list more artifacts of the development process on my end, so prefer to keep them out of the remote. If you think they should be in the repo, I can union yours with mine. Similar story with Rproj, just prefer to keep my own Rproj locally.

muschellij2 commented 5 years ago

I tend to have them on GitHub as I like someone have the ability to open the project in RStudio. Also, they are ignore files, so I don't mind them being a bit bloated. If you feel strongly otherwise, though, I will drop them.

pamelarussell commented 5 years ago

I don't feel strongly, so let's keep them in the remote. Merging. Thanks!

I'm waiting a bit to submit a new version to CRAN to avoid getting an earful from the maintainers.