Closed MaciejWanat closed 3 years ago
This failed test is passing when ran directly, doesn't when tests are run altogether.
Using method.DeclaringType.FullName
ends up with behaving in really strange way, so I've changed it to method
, which should work just as good - tests passes correctly.
@pamidur when is this change expected to be realeased?
Monday-Tuesday I think, I have a few more fixes in mind.
@MaciejWanat, one thing I will change is PerInstance by default equals true, to be backward compatible with previous versions
@pamidur good idea, I was thinking about the same suggestion
I also found an issue in AI with properties from base classes in attributes, I need to fix before the release
I've done a bit more than I suggested in https://github.com/pamidur/aspect-injector/issues/144, so here's the list of things I've done:
PerInstance
is great! The only difference I made is that I believe default behavior should NOT be per instance. If you think it should be otherwise, it will be easy to changeGetKey
now has two overloads - with and without instance. I also changed it to beprotected
insteadprivate
, so anyone can define their own way of creating a key, in they way they find suitable, by overriding these methods.I got a bit confused in line 58, because there are no tests for multiple triggers. So I figured I will use
Any
to define which key to use, but I'm not sure whether its correct.I hope you like the changes :)