search

pamidur / aspect-injector

AOP framework for .NET (c#, vb, etc)
Apache License 2.0
742 stars 111 forks source link

Feature: Provide debug symbols with NuGet package #207

Open neparij opened 1 year ago

neparij commented 1 year ago

Describe the solution you'd like Symbols package (snupkg) provided for NuGet. This way all dependant packages can use it while signing itself.

Additional context There is no PDB Metadata for AspectInjector.Broker library at the moment.

Screenshot 2023-01-31 at 12 51 33
pamidur commented 1 year ago

Hey @neparij , I didn't know signing requires PDB files. Would it be enough if I add the PDB into main package or it has to be snupkg?

neparij commented 1 year ago

Hey @neparij , I didn't know signing requires PDB files. Would it be enough if I add the PDB into main package or it has to be snupkg?

For example, you can run dotnet pack command with the --include-symbols argument. After symbols was created dotnet nuget push command should attach generated .snupkg files as well. Don't forget to add <SymbolPackageFormat>snupkg</SymbolPackageFormat> to your PropertyGroup in csproj Also, I recommend using Microsoft.SourceLink with github adaptor (Clarifying README provided on their repository)