panamax-rs / panamax

Mirror rustup and crates.io repositories, for offline Rust and cargo usage.

Apache License 2.0

443 stars 46 forks source link

Bug in sync rustup-init files for windows platforms #48

Closed TalRoni closed 2 years ago

TalRoni commented 3 years ago

rustup-init files in windows platforms need .exe extension in the download url The sync_rustup_init always call to sync_one_init with is_exe=false as parameter

TalRoni commented 3 years ago

49

TalRoni commented 3 years ago

Hi @k3d3 Do you have any comments about this patch? want to make the changes? Thanks

LukeMauldin commented 2 years ago

This is impacting me because I cannot replace Romt with Panamax because Rustup-init files for windows are not being downloaded.

k3d3 commented 2 years ago

I've merged PR #49, which should fix this bug. Feel free to reopen this issue if it still persists.