search

panbachi / wordclock

DIY WordClock
https://www.panbachi.de/eigene-word-clock-bauen/
MIT License
108 stars 47 forks source link

Make brightness configurable #4

Closed ibrot closed 4 years ago

napsio commented 4 years ago

Thank you for your pull-request, but there are several problems.

  1. your code ist not mergeable to the new version

  2. I would prefer another solution: There has to be a defined max-brightness in the user_config.h. The max-brightness depends on the count of LEDs and the power supply. Each (WS2812b) LED needs 0.06A on full brightness in white color. There has to be a possibility to set the brightness from 0 to max-brightness. But in the UI I would prefer a range beween 0 and 100. So the setBrightness parameter has to be calculated (like: MAX_BRIGHTNESS * Config.brightness / 100).

I hope you understand what I mean :)

ibrot commented 4 years ago

Hi,

yes I saw that you changed a lot in the code. I like the new organized code :)

Thank you for your thoughts. I will play around a bit and will come up with a new solution based on your suggestion :)