pancakeswap / pancake-frontend

:pancakes: Pancake main features (farms, pools, IFO, lottery, profiles)
https://pancakeswap.finance
GNU General Public License v3.0
2.7k stars 3.55k forks source link

fix: Warning not seen trx deadline setting, set value only when losing focus #10904

Closed memoyil closed 2 weeks ago

memoyil commented 3 weeks ago

Current behaviour is misleading that it sets it to user ttl on every digit removal


PR-Codex overview

This PR focuses on improving error handling for the deadlineInput state in the SlippageTabs component. It introduces the use of useEffect to manage the deadlineError state and enhances input validation.

Detailed summary

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2024 10:44am
6 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **aptos-web** | ⬜️ Ignored ([Inspect](https://vercel.com/pancakeswap/aptos-web/2ymdsmcrR3gbt6Q8sN1yvfsnni5y)) | [Visit Preview](https://aptos-web-git-feature-fixdeadlinesettingwarningandsetvalue.pancake.run) | | Nov 3, 2024 10:44am | | **blog** | ⬜️ Ignored ([Inspect](https://vercel.com/pancakeswap/blog/6AoqZPuKAwoT3XZjaTJC6fQTwDrn)) | [Visit Preview](https://blog-git-feature-fixdeadlinesettingwarningandsetvalue.pancake.run) | | Nov 3, 2024 10:44am | | **bridge** | ⬜️ Ignored ([Inspect](https://vercel.com/pancakeswap/bridge/5LmZz4vxtGFjvDjQwiBxs9puitH9)) | [Visit Preview](https://bridge-git-feature-fixdeadlinesettingwarningandsetvalue.pancake.run) | | Nov 3, 2024 10:44am | | **games** | ⬜️ Ignored ([Inspect](https://vercel.com/pancakeswap/games/C5pUe526n1w2JWW6jQ6W1dMtXLZp)) | [Visit Preview](https://games-git-feature-fixdeadlinesettingwarningandsetvalue.pancake.run) | | Nov 3, 2024 10:44am | | **gamification** | ⬜️ Ignored ([Inspect](https://vercel.com/pancakeswap/gamification/2UmCEcCRcBKHWRHs4QFoMgXqZ4AC)) | | | Nov 3, 2024 10:44am | | **uikit** | ⬜️ Ignored ([Inspect](https://vercel.com/pancakeswap/uikit/H2W84U7bN953jgrUVJNmebbUGax7)) | [Visit Preview](https://uikit-git-feature-fixdeadlinesettingwarningandsetvalue.pancake.run) | | Nov 3, 2024 10:44am |
changeset-bot[bot] commented 3 weeks ago

⚠️ No Changeset found

Latest commit: 9ceff81d42ccbd708a60877e8495ac4e2f461760

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR