Closed chef-ryan closed 1 day ago
Latest commit: fbb55c04b7bdbc4097c0803a2426c32fef171b1f
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
web | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Nov 26, 2024 5:33am |
PR-Codex overview
This PR focuses on improving the dismissal handling of the
AddGaugeModal
component by introducing adismissHandler
function. This function resets the search text and calls theonDismiss
callback, ensuring a consistent state when the modal is closed.Detailed summary
dismissHandler
function usinguseCallback
to reset search text and handle modal dismissal.onDismiss
prop in<ModalV2>
to usedismissHandler
instead of directly callingonDismiss
.onClick
prop of the close button to usedismissHandler
.onClick
prop of<BottomAction>
to usedismissHandler
.