fix: Updated functional props cannot rerender modal causes modal to not work properly

[memoyil]

To reproduce:

Go to v3 increase liquidity Click increase after selecting token amounts See increase button not working

Root cause:

Deadline variable at the time modal rendered not yet available therefore it causes onIncrease return without calling the tx. Even the deadline variable (which needs blocktimestamp rpc call to return) ready after some seconds modal cannot be updated due to functional props stringify is as same as old one.

---

PR-Codex overview

This PR focuses on optimizing several components by using useCallback to memoize functions, which helps prevent unnecessary re-renders in React applications. This improves performance and maintains the stability of function references.

Detailed summary

• Updated handleBeforeDismiss in AddressSearch.tsx to use useCallback.
• Refactored modal content in RemoveLiquidityV3.tsx to use useCallback.
• Changed onAdd in AddLiquidity/index.tsx to a useCallback function.
• Updated onSuccess in CollectWinningsButton.tsx to use useCallback.
• Refactored onAdd in AddStableLiquidity/index.tsx to use useCallback.
• Changed onRemove in RemoveStableLiquidity/index.tsx to a useCallback function.
• Updated onRemove in RemoveLiquidity/index.tsx to use useCallback.
• Refactored modalHeader in liquidity/[tokenId].tsx to use useCallback.
• Updated handlePickedRewardToken in SubmitAction/index.tsx to use useCallback.
• Refactored handleStake and handleUnstake in FarmTable/Actions/StakedAction.tsx to use useCallback.
• Updated handleStake and handleUnstake in FarmCard/StakeAction.tsx to use useCallback.
• Introduced splitFunctionProps in useModal.ts to manage function props efficiently.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

[changeset-bot[bot]]

⚠️ No Changeset found

Latest commit: 1ef39867b2c13409f827ea8f193add6fcee1a5b7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
aptos-web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 25, 2024 8:15am
blog	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 25, 2024 8:15am
bridge	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 25, 2024 8:15am
games	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 25, 2024 8:15am
gamification	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 25, 2024 8:15am
uikit	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 25, 2024 8:15am
web	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 25, 2024 8:15am