pancakeswap / pancake-frontend

:pancakes: Pancake main features (farms, pools, IFO, lottery, profiles)
https://pancakeswap.finance
GNU General Public License v3.0
2.69k stars 3.55k forks source link

[BUG] Failed to compile src\components\Modal\ModalInput.tsx, Line 12:3: 'placeholder' PropType is defined but prop is never used react/no-unused-prop-types #2025

Closed arbin304 closed 2 years ago

arbin304 commented 3 years ago

Is there an existing issue for this?

Product

Other

Current Behavior

Pancake-Frontend is throwing random Type errors when uikit is installed from symlinked project. It runs fine when @pancake-uikit is installed from npm. The errors I'm getting right now is given below.

src\components\Modal\ModalInput.tsx
  Line 12:3:  'placeholder' PropType is defined but prop is never used  react/no-unused-prop-types

src\components\PageSection\CurvedDivider.tsx
  Line 7:3:  'svgFill' PropType is defined but prop is never used  react/no-unused-prop-types

src\views\AddLiquidity\index.tsx
  Line 254:9:  JSX props should not use functions  react/jsx-no-bind

src\views\FarmAuction\components\AuctionDetailsCard\AuctionSchedule.tsx
  Line 18:3:  'showForClosedAuction' PropType is defined but prop is never used  react/no-unused-prop-types

src\views\Pools\components\PoolCard\CardFooter\index.tsx
  Line 13:3:  'totalCakeInVault' PropType is defined but prop is never used  react/no-unused-prop-types

src\views\Predictions\components\RoundCard\CardHeader.tsx
  Line 11:3:  'blockNumber' PropType is defined but prop is never used  react/no-unused-prop-types

src\views\Profile\components\ConfirmProfileCreationModal.tsx
  Line 16:3:  'userName' PropType is defined but prop is never used  react/no-unused-prop-types

src\views\RemoveLiquidity\index.tsx
  Line 378:93:  JSX props should not use functions  react/jsx-no-bind
  Line 447:48:  JSX props should not use functions  react/jsx-no-bind
  Line 447:73:  JSX props should not use functions  react/jsx-no-bind
  Line 637:19:  JSX props should not use functions  react/jsx-no-bind

Search for the keywords to learn more about each error.

Expected Behavior

Being able to run pancake-uikit repo along with pancake-frontend to tweak the components.

Steps To Reproduce

  1. Clone pancake-frontend and pancake-toolkit repos.
  2. Run yarn install and yarn build.
  3. Create symlink for @pancakeswap/uikit using yarn link in pancake-toolkit/packages/pancake-uikit .
  4. Run yarn link '@pancakeswap/uikit' in pancake-frontend project.
  5. Run yarn install --force
  6. Run yarn start

Environment

- Device: Asus
- OS: Windows 10
- Browser: Chrome
- Wallet: Metamask

Anything else?

There actually are few errors with types in the pancake-frontend project, but doesnt show up unless I run symlinked uikit.

nslogx commented 3 years ago

+1

Squiji commented 3 years ago

+1

Jokers-Exchange commented 3 years ago

+1

Jokers-Exchange commented 3 years ago

Having the same problem here and I can't seem to fix it.

(edit) I was able to finally fix the problem.

CRuzylo commented 3 years ago

Having the same problem here and I can't seem to fix it.

(edit) I was able to finally fix the problem. Curious how?

Squiji commented 3 years ago

Sure, what’d you need to do?

On Sun, Oct 10, 2021 at 2:36 AM CRuzylo @.***> wrote:

Having the same problem here and I can't seem to fix it.

(edit) I was able to finally fix the problem. Curious how?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pancakeswap/pancake-frontend/issues/2025#issuecomment-939440477, or unsubscribe https://github.com/notifications/unsubscribe-auth/AL5P3HO2Y3OWKXU6R7G5RQ3UGFNAVANCNFSM5DBFVWBQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

PancakeSwap-bot commented 2 years ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 2 days.