search

pancakeswap / pancake-toolkit

:hammer_and_pick: Pancake frontend packages
https://pancakeswap-uikit.netlify.app/
GNU General Public License v3.0
305 stars 753 forks source link

fix(CI): Add prevent break build #302

Closed lioncho closed 2 years ago

lioncho commented 2 years ago

[x] Before opening a pull request, please read the contributing guidelines first [x] If your PR is work in progress, open it as draft [x] Before requesting a review, all the checks need to pass [x] Explain what your PR does build breaking was always issue, this will work for preventing break build.

Chef-Cheems commented 2 years ago

@ryancho Hi! What do you mean that build break is an issue? I don't remember many PRs that got red because build failed 🤔 And building on every commit seems a bit too much...

lioncho commented 2 years ago

@ryancho Hi! What do you mean that build break is an issue? I don't remember many PRs that got red because build failed 🤔 And building on every commit seems a bit too much...

Yes I agree that is bit too much.

RabbitDoge commented 2 years ago

Building on commit-msg hook doesn't seem appropriate

memoyil commented 2 years ago

Imho pre commit hooks should only contain formatting and linting checks

Chef-Cheems commented 2 years ago

Closing as not necessary 😶 Its fine if build fails, just fix and commit 🤷‍♂️