search

pancakeswap / pancake-uikit

💠 Set of UI components for pancake projects
https://pancakeswap.github.io/pancake-uikit/
77 stars 382 forks source link

Feat/slider #196

Closed PetterIve closed 3 years ago

PetterIve commented 3 years ago

Fixes https://github.com/pancakeswap/pancake-frontend/issues/530. I assumed this was the place to add this, even tho the issue is open in another repo. I could move the code to the other repo if needed.

Before this is ready, I need to get in touch with someone from the design team, as there's an issue with the bunnyhead svgs when I export them from Figma -- their height is too high.

Also, it needs to be decided whether the label should be decided within this component. Not sure how you want to solve that wrt. localization.

PetterIve commented 3 years ago

@Chef-Chungus tagging you here as you're the one posting the bounty, please forward to the appropriate maintainer if it's not you :)

I need the following to finish:

  1. Fix bunny head svgs (not sure why the export from Figma isn't working, things in Figma seems correct), would be nice to get in touch with a designer (I joined the Slack)
  2. What do we do wrt. localization and the MAX in the label for 100%?
  3. The component doesn't take any extra props currently, such as style etc. Do you have a preferred solution for this?
RabbitDoge commented 3 years ago

See with @ChefBugs for the design problems

PetterIve commented 3 years ago

Hi, thanks for the feedback, think I got most of it covered. Also got some updated svgs, so now it should be ready :)

Wrt. lint: I'm on an old computer currently, and VSCode is acting up a bit, but I've been running yarn format before committing (and prettier seems to be running with a husky hook as well). Not familliar with your preferred prettier config, does it still look wrong?

Wrt. the svgs: They are just used in the styles (no react rendered svgs), which is why I didn't use react svg for it. Not sure if it makes sense when we just need it as an image link in the CSS? (Maybe you have a preferred way of dealing with assets..?)

hachiojidev commented 3 years ago

@PetterIve We will get this sorted out automatically but for now can you create a build of the storybook and send us a link so we can test the UI? You can use a free service like GH, Surge, Vercel or Netlify.