search

pancakeswap / pancake-v4-core

GNU General Public License v2.0
52 stars 36 forks source link

Prepare `owner` contract #161

Closed ChefMist closed 1 month ago

ChefMist commented 2 months ago

Per this PR: https://github.com/pancakeswap/pancake-v4-core/pull/139

In order to reduce contract size, we did the above PR and in doing so, PausableRole has been removed.

Now we need a owner contract which

  1. A way for others to call the owner contract to pause pool manager. eg. others --> owner contract --> poolManager.pause()
  2. A way in the owner contract to whitelist who can call pause()
ChefSnoopy commented 2 months ago

ok, got it

ChefMist commented 1 month ago

take into account of https://github.com/pancakeswap/pancake-v4-core/pull/169

ChefMist commented 1 month ago

design choices

Option 1: Both pool manager point to the same contract

Option 2: Each pool manager will have its own contract

ChefSnoopy commented 1 month ago

design choices

Option 1: Both pool manager point to the same contract

Option 2: Each pool manager will have its own contract

I vote option 2

chefburger commented 1 month ago

design choices Option 1: Both pool manager point to the same contract Option 2: Each pool manager will have its own contract

I vote option 2

Agree, as option2 provides more flexibility. They can point to same address tho