pancakeswap / pancake-v4-core

GNU General Public License v2.0
52 stars 36 forks source link

[Discuss]feat/refactor account delta for app #171

Closed ChefSnoopy closed 1 month ago

ChefSnoopy commented 1 month ago

Remove parameter app from _accountDeltaForApp , will save some gas. Not much , only 10 ~ 20 , just leave here for reference

chefburger commented 1 month ago

i don't have strong opinion on this, it does save gas and relatively risk free.

@chefburger any thoughts?

lgtm as well, dont see any drawback

chefburger commented 1 month ago

btw @ChefSnoopy , before u merge can you also remove PoolKey from IVault. It seems now Vault can be PoolKey agnostic 👏

CleanShot 2024-09-12 at 11 41 54@2x