pancakeswap / pancake-v4-periphery-deprecated

GNU General Public License v2.0
13 stars 6 forks source link

consider rewriting `amountOutCached` with transient storage #42

Closed chefburger closed 4 months ago

chefburger commented 4 months ago
          consider rewriting with transient storage

_Originally posted by @chefburger in https://github.com/pancakeswap/pancake-v4-periphery/pull/39#discussion_r1644102902_

ChefSnoopy commented 4 months ago

The quoter should not be called on-chain. It will be used by static call in FE. So gas optimization is meaningless.

chefburger commented 4 months ago

The quoter should not be called on-chain. It will be used by static call in FE. So gas optimization is meaningless.

Agree, i almost forgot this lol.