pancakeswap / pancake-v4-periphery-deprecated

GNU General Public License v2.0
13 stars 6 forks source link

Consider using Safecast whenever do integer casting #54

Open chefburger opened 4 months ago

chefburger commented 4 months ago

Per internal review:

One thing i notice is a bunch of casts to uin128 from larger data types, like uint256 E.g.

https://github.com/pancakeswap/pancake-v4-periphery/blob/bd5b3691e8cd19ff01115eae8b985a07fb5715c2/src/pool-cl/NonfungiblePositionManager.sol#L454