pancakeswap / pancake-v4-periphery

GNU General Public License v2.0
5 stars 3 forks source link

emit balanceDelta in ModifiedLiquidity event #16

Open chefburger opened 2 weeks ago

chefburger commented 2 weeks ago

Current "MintPosition" event doesn't provide information about how many token0/token1 need to be settled by positionManager for the on-going action.

Consider update to

    /// @notice Emitted when liquidity is modified
    /// @param tokenId the tokenId of the position that was modified
    /// @param liquidityChange the change in liquidity of the position
    /// @param delta the total balance delta of the caller of modifyLiquidity.
    /// @param feesAccrued the fees collected from the liquidity change
    event ModifyLiquidity(uint256 indexed tokenId, int256 liquidityChange, BalanceDelta delta, BalanceDelta feesAccrued);