panda-official / TimeSwipe

PANDA Timeswipe driver and firmware
GNU General Public License v3.0
3 stars 5 forks source link

transfer driver/example to driver/examples #10

Closed IngoKaiser closed 4 years ago

IngoKaiser commented 4 years ago

please transfer dir into examples with name - "DataLogging"

and add some code to main to store data of all sensors in tsv-format just like in old project.

iluxa commented 4 years ago

PR created https://github.com/panda-official/TimeSwipe/pull/18:

IngoKaiser commented 4 years ago

Move sleep back into user loop. Or lets discuss another way - just the way we talked about it on channel.

iluxa commented 4 years ago

Moved sleep back to the user, new PR: https://github.com/panda-official/TimeSwipe/pull/19

IngoKaiser commented 4 years ago

hey @iluxa beside changes I am missing integration of properly saving data in file ;) Please Check that and do integration.

iluxa commented 4 years ago

current version let user put --dump flag and redirect standard output to the file. I thinks it is a good way to save data to the file, original version has filename hardcoded, should we add new option like --output for user to save into the file or keep this implementation with redirecting standard output?

IngoKaiser commented 4 years ago

@iluxa thats a very good idea

iluxa commented 4 years ago

@k41532 what exactly good - leave it as it is or add --output flag?

IngoKaiser commented 4 years ago

šŸ˜I mean your idea. ā€”output flag

IngoKaiser commented 4 years ago

Letā€™s also switch config behavior.

Letā€™s put chosen input type as selection in there not as option to be chosen by additional flag as flag as of now.

Letā€™s work with flag ā€”config therefore. When none is set we use NORM as default with 0 for each offset and 1 for all gains and transmissions.

@iluxa What do you think?

iluxa commented 4 years ago

yes, then command line will be:

./main [--config <filename>] [--input <input_type>] [--output <filename>]

config.json is default for --config option first input type from config file is default for --input option

IngoKaiser commented 4 years ago

perfect

iluxa commented 4 years ago

added PR https://github.com/panda-official/TimeSwipe/pull/21