Fix off-by-1 error in stringsearch.

panda-re / panda

Platform for Architecture-Neutral Dynamic Analysis

https://panda.re

Other

2.47k stars 474 forks source link

Fix off-by-1 error in stringsearch. #1427

Closed MarkMankins closed 7 months ago

MarkMankins commented 7 months ago

Memory callbacks were not being enabled when using a stringsearch file that contained exactly one string. Enable callbacks when the first string is read from the file, not the second string.

lacraig2 commented 7 months ago

Nice catch. Will merge once the CI accepts it.

MarkMankins commented 7 months ago

CI always errors out on my PRs - if there is something I can do on my side to fix that let me know.

AndrewFasano commented 7 months ago

The build_container CI job (at least) has been broken since #1387 where it tries pushing a container to dockerhub on PRs which (fortunately) fails due to a permissions issue. Not sure what happened with the publish deb failure here, but it's clearly unrelated to your changes.