panda-re / panda

Platform for Architecture-Neutral Dynamic Analysis
https://panda.re
Other
2.45k stars 475 forks source link

Callstack_instr: disable TB chaining to improve accuracy #1485

Closed AndrewFasano closed 4 months ago

AndrewFasano commented 4 months ago

1447 switches callstack_instr to use start block exec callbacks instead of before block exec to fix an issue where tb chaining causes calls to be missed. That PR is based off a now-reverted change in #1445. Unfortunately the changes in #1447 have revealed some unexpected non-determinism around the SBE callback that we're trying to track down before merging it.

This PR acts as an interim fix for callstack_instr to improve its accuracy by ensuring tb chaining is disabled.