pandaos / panda-qt5-plugin

Unify Qt application style of PandaOS.
0 stars 0 forks source link

Could not find a package configuration file provided by "libpanda-files" #1

Open probonopd opened 4 years ago

probonopd commented 4 years ago

Cannot compile:

  Could not find a package configuration file provided by "libpanda-files"
  with any of the following names:

    libpanda-filesConfig.cmake
    libpanda-files-config.cmake

  Add the installation prefix of "libpanda-files" to CMAKE_PREFIX_PATH or set
  "libpanda-files_DIR" to a directory containing one of the above files.  If
  "libpanda-files" provides a separate development package or SDK, be sure it
  has been installed.

-- Configuring incomplete, errors occurred!
See also "/tmp/panda-qt5-plugin/build/CMakeFiles/CMakeOutput.log".

Please advise. Thank you.

probonopd commented 4 years ago

I can compile it with this patch

diff --git a/platformthemeplugin/CMakeLists.txt b/platformthemeplugin/CMakeLists.txt
index 1bc8b1a..6cdc770 100644
--- a/platformthemeplugin/CMakeLists.txt
+++ b/platformthemeplugin/CMakeLists.txt
@@ -13,7 +13,6 @@ find_package(Qt5Gui CONFIG REQUIRED Private)
 find_package(Qt5XdgIconLoader REQUIRED)
 find_package(dbusmenu-qt5 REQUIRED)
 find_package(KF5WindowSystem REQUIRED)
-find_package(libpanda-files REQUIRED)

 # dependencies for QPA plugin
 find_package(Qt5ThemeSupport REQUIRED)
@@ -50,17 +49,6 @@ qt5_add_dbus_adaptor(SRCS
     StatusNotifierItem
 )

-get_target_property(LIB_FM_QT_CONFIGURATIONS libpanda-files IMPORTED_CONFIGURATIONS)
-if (LIB_FM_QT_CONFIGURATIONS)
-    # Extract the .soname from the first configuration found.
-    # We don't use configuration mapping. Any config serves the purpose
-    list(GET LIB_FM_QT_CONFIGURATIONS 0 LIB_FM_QT_FIRST_CONFIGURATION)
-    get_target_property(LIB_FM_QT_SONAME libpanda-files IMPORTED_SONAME_${LIB_FM_QT_FIRST_CONFIGURATION})
-else()
-    message(ERROR "libpanda-files, but no configuration found. Check your libpanda-files installation.")
-endif()
-mark_as_advanced(LIB_FM_QT_SONAME)
-
 add_library(panda-qtplugin MODULE ${SRCS})

 target_compile_definitions(panda-qtplugin

Not sure whether this breaks critical functionality. But at least I can compile.

probonopd commented 4 years ago

When I run an application with QT_QPA_PLATFORMTHEME=panda vlc, then the menu does show up. Good! :+1:

reionwong commented 4 years ago

Removing panda-files dependencies did not destroy key functions, It provides a unified open file dialog box for all qt applications here :+1:

reionwong commented 4 years ago

look here: https://github.com/pandaos/panda-qt5-plugin/blob/92abb2fb574103c1cea593a224287e93bfad9f1e/platformthemeplugin/pandaplatformtheme.cpp#L121