Closed loicdiridollou closed 1 month ago
/pandas_nightly
Happy to merge or wait if you want to remove
__init__
first
I deleted the __init__
method, just waiting for CI to finish but it is looking ready from a code perspective.
Thanks @loicdiridollou !
FYI, I think we should have kept __init__()
and deleted __new__()
. In the stubs, we only need to have __new__()
if we want to have different overloads that produce different results. Otherwise __init__()
is sufficient.
Admittedly, we're inconsistent in the stubs about that. There are times we use __new__()
instead of __init__()
Admittedly, we're inconsistent in the stubs about that. There are times we use
__new__()
instead of__init__()
If we want to become more stubtest compatible (aligning pandas and pandas-stubs), we should use which ever constructor pandas uses, at least when possible.
assert_type()
to assert the type of any return value