fix signature of frame.filter - Githubissues

pandas-dev / pandas-stubs

Public type stubs for pandas

BSD 3-Clause "New" or "Revised" License

230 stars 123 forks source link

fix signature of frame.filter #964

Closed refack closed 2 months ago

refack commented 2 months ago

items can be ListLike

It is turned into and Index which can handle and ListLike as data https://github.com/pandas-dev/pandas/blob/9b375be5aa3610e8a21ef0b5b81e4db04270f3d3/pandas/core/generic.py#L5448

[ ] Closes #xxxx (Replace xxxx with the Github issue number)
[ ] Tests added: Please use assert_type() to assert the type of any return value

refack commented 2 months ago

Can you add a test

Allready started (great minds and such)

Dr-Irv commented 2 months ago

CI is failing because pyright got upgraded and we have to remove some #pyright ignore statements. This is in PR #967 . Once that is merged in, then you can merge in the new main in your branch and push, and I will test the CI again.

Dr-Irv commented 2 months ago

CI is failing because pyright got upgraded and we have to remove some #pyright ignore statements. This is in PR #967 . Once that is merged in, then you can merge in the new main in your branch and push, and I will test the CI again.

This is now merged, so go ahead and merge with main and push

refack commented 1 month ago

Thanks @refack

Keep up the great work

refack commented 1 month ago

@Dr-Irv apropos, I just stumbled on https://github.com/pandas-dev/pandas/issues/47215 LOL It's nice to see things stay consistent even after 2 years 👍