GroupBy[Series].count() return type should be Series[int]

pandas-dev / pandas-stubs

Public type stubs for pandas

BSD 3-Clause "New" or "Revised" License

234 stars 125 forks source link

Closed chrisyeh96 closed 3 months ago

chrisyeh96 commented 3 months ago

[X] Closes #965
[X] Tests added: Please use assert_type() to assert the type of any return value

Dr-Irv commented 3 months ago

We just uncovered an issue with our CI that was fixed earlier today. Can you merge with current main and push? Then I will start the CI runs.

chrisyeh96 commented 3 months ago

I have merged pandas-dev/main into my fork

Dr-Irv commented 3 months ago

Ugh, so now CI is failing because when you first tested, it used pyright 1.1.373 and that got locked for further tests.

Can you include this in your PR? In pyproject.toml, change:

pyright = ">=1.1.369"

pyright = ">= 1.1.374"

chrisyeh96 commented 3 months ago

I have updated the pyright dependency version in pyproject.toml as you suggested.