Use the new TypeIs feature to update the notna/notnull/isna/isnull type guards

pandas-dev / pandas-stubs

Public type stubs for pandas

BSD 3-Clause "New" or "Revised" License

234 stars 125 forks source link

Use the new TypeIs feature to update the notna/notnull/isna/isnull type guards #972

Closed loicdiridollou closed 3 months ago

loicdiridollou commented 3 months ago

[x] Closes #911
[x] Tests added: Please use assert_type() to assert the type of any return value

loicdiridollou commented 3 months ago

Thanks @gandhis1 for the feedback.

steve-mavens commented 1 month ago

I think this change isn't quite correct: https://github.com/pandas-dev/pandas-stubs/issues/1009. The return value of this function doesn't actually discriminate the type, because some float are NaN and others aren't.