Restore nightly CI build due to new pandas version (3.0.0)

pandas-dev / pandas-stubs

Public type stubs for pandas

BSD 3-Clause "New" or "Revised" License

230 stars 123 forks source link

Restore nightly CI build due to new pandas version (3.0.0) #974

Closed loicdiridollou closed 1 month ago

loicdiridollou commented 1 month ago

[x] Closes #973
[x] Tests added: Please use assert_type() to assert the type of any return value

We can probably be a little more elegant in some of the pytest_warn_bounds where we define a variable then redefine it the line below if we are dealing with pandas 3.0.0, open to suggestions.

Dr-Irv commented 1 month ago

We can probably be a little more elegant in some of the pytest_warn_bounds where we define a variable then redefine it the line below if we are dealing with pandas 3.0.0, open to suggestions.

I'm open to better ways of doing the tests here, but will accept this PR as is.

Dr-Irv commented 1 month ago

@loicdiridollou looks like the fix for test_versions() didn't work. See https://github.com/pandas-dev/pandas-stubs/actions/runs/10289869197/job/28478532479

loicdiridollou commented 1 month ago

Arghh I thought I had it fixed, sorry for that let me investigate and fix.

loicdiridollou commented 1 month ago

I was able to have a running build on my own repo, see https://github.com/loicdiridollou/pandas-stubs/actions/runs/10290769879/job/28481506269. The PR is here (https://github.com/pandas-dev/pandas-stubs/pull/975), the issue was that pandas>=3.0.0 does not seem to rely on distutils anymore so the warning was never raised to the user