Allow tuple-valued params in read_sql[_query]

pandas-dev / pandas-stubs

Public type stubs for pandas

BSD 3-Clause "New" or "Revised" License

234 stars 125 forks source link

Allow tuple-valued params in read_sql[_query] #997

Closed sh-at-cs closed 2 months ago

sh-at-cs commented 2 months ago

[x] Closes #996
[ ] Tests added: Kind of:
- As explained in https://github.com/pandas-dev/pandas-stubs/issues/996, the added types are not valid for SQLite databases/drivers, so it's not possible to add a test that actually executes without major changes to the CI setup. But I've added a skipped test instead so that at least the type checking part of the CI pipeline can check if the new annotations are at all sane.

Dr-Irv commented 2 months ago

You need to run black on your changed files, or follow the instructions at https://github.com/pandas-dev/pandas-stubs/blob/main/docs/setup.md to set up your environment and install the pre-commit checks.

sh-at-cs commented 2 months ago

Sorry, I ran my system black on it which had a different version and hence slightly different formatting. Should be fixed now - at least pre-commit runs without errors.