search

pandas-dev / pandas

Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more
https://pandas.pydata.org
BSD 3-Clause "New" or "Revised" License
43.62k stars 17.91k forks source link

2to3 refactor broke vbenches #4477

Closed ghost closed 11 years ago

ghost commented 11 years ago

looks like lmap is now called by some vbenches, which breaks the tests on all older versions.

.....................................................groupby_transform died with:
name 'lmap' is not defined
Skipping...

groupby_transform died with:
name 'lmap' is not defined
Skipping...

4384, #4474

jtratner commented 11 years ago

@y-p how do the vbenches work? Are they supposed to contain only code that works through the last X revisions?

ghost commented 11 years ago

test_perf is meant to allow before/after perf for sanity checking PRs, but the underlying vbench tool and vbench suite is geared towards long term perf tracking. With that in mind, vbenches should be portable as far back into pandas' history as is possible.