pandas-dev / pandas

Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more
https://pandas.pydata.org
BSD 3-Clause "New" or "Revised" License
43.82k stars 17.99k forks source link

TST: Update IntervalArray min/max test to fail on changed default skipna #59747

Closed jsngn closed 2 months ago

jsngn commented 2 months ago

Before, if the line core/arrays/interval.py:866 is changed from def min(self, *, axis: AxisInt | None = None, skipna: bool = True) -> IntervalOrNA: to def min(self, *, axis: AxisInt | None = None, skipna: bool = False) -> IntervalOrNA:, all tests still passed. Now they will fail if the default skipna param is updated, perhaps mistakenly.

Applies to max() method too since they are tested in the same test function.

jsngn commented 2 months ago

@mroeschke Could you take a look? Thank you!

mroeschke commented 2 months ago

Thanks @jsngn