search

pandastrike / huxley

API and CLI for Docker Deployment
9 stars 1 forks source link

Improve Error Handling for "huxley remote" #56

Open freeformflow opened 9 years ago

freeformflow commented 9 years ago

huxley remote uses panda-hook to add and remote githooks. Unfortunately, the error handling is buggy. It will come back with a success even if the operation failed. Please make it so this does not happen. We will probably need capture errors from shell commands in panda-hook better to achieve this.

freeformflow commented 9 years ago

@peterlnguyen, Even though we'll have use of the pending sub-command in the CLI, huxley remote still lacks the ability to warn the user when it fails to set things up on the hook server. That's a pretty glaring problem, so implementing some better handling is a valuable upgrade.

I'm assigning this to you for Alpha 04. Please look into getting the panda-hook library to throw errors. These errors bubble up to the Huxley API handler, and we'll want the API to respond to the user appropriately.