search

pandastrike / jsck

JSON Schema Compiled checK
MIT License
160 stars 14 forks source link

Include mc-schema in bechmarks, It's faster #76

Closed mctep closed 9 years ago

mctep commented 9 years ago

Hi! Can I take part in the competition https://github.com/pandastrike/jsck/issues/72? :-)

https://github.com/mctep/mc-schema

It passes all tests from https://github.com/json-schema/JSON-Schema-Test-Suite except of:

var IGNORE = [
    'zeroTerminatedFloats.json',
    'refRemote.json',
    'one supplementary Unicode code point is not long enough',
    'two supplementary Unicode code points is long enough'
];
mctep commented 9 years ago

Forget it. I found some problems :-)

mctep commented 9 years ago

Ok. I can suggest that you use the same schema objects between tests in bencmarks. So modules cans to affect tests between modules (like z-schema). May be you should cloning schema object before setup lib?

automatthew commented 9 years ago

May be you should cloning schema object before setup lib?

Yes, I think this would be a good prophylactic measure

gilesbowkett commented 9 years ago

In an ideal world, I wouldn't mind breaking out the benchmarks into their own repo. As it is, we can make tickets for these suggestions if need be.

mctep commented 9 years ago

Of course it is up to your up to deside. I have noticed that you have comments like:

## Disabled because it refuses to accept one of our schema

As for the subject of the issue is-my-json-valid is faster than mc-schema according to your benchmarks. So I closed it.

automatthew commented 9 years ago

@mctep

I have noticed that you have comments like...

I don't want to exclude any reasonable project, but I can't include validators that say a valid document is invalid. Now that we have json-schema-tests, we can better assess problems with other validators and give the authors information on where they're failing.

automatthew commented 9 years ago

As for the subject of the issue is-my-json-valid is faster than mc-schema according to your benchmarks. So I closed it.

Mere speed isn't the only consideration. There are some features that I need in a validator that I would be willing to sacrifice performance to have. I'd like to include your lib in the benchmarks whether or not it's the front-runner.

mctep commented 9 years ago

Now that we have json-schema-tests

It's a really great idea. I'will keep an eye on. Can I ask you some questions by email about this?

automatthew commented 9 years ago

Can I ask you some questions by email about this?

Yes. My email's in my GitHub profile.