Add themis to benchmarks

pandastrike / jsck

JSON Schema Compiled checK

MIT License

158 stars 14 forks source link

Add themis to benchmarks #82

Closed atrniv closed 9 years ago

atrniv commented 9 years ago

Themis has several configuration options which can affect its performance. As such I've added 2 validators in the benchmarks. Themis[minimal] (minimum features enabled) and just Themis (full support for default values enabled).

Signed-off-by: Johny Jose johny@playlyfe.com

gilesbowkett commented 9 years ago

some comments on https://github.com/pandastrike/jsck/issues/81.

I'm basically happy to merge this, with a few caveats:

I just woke up so I'm going to have an espresso first.
You made these changes on your master branch and we really absolutely prefer that changes like this happen on a feature branch and then get merged into master afterwards.
"Themis[minimal]" has to become "Themis (minimal)." I can make that change myself, though.

gilesbowkett commented 9 years ago

I'm running json-schema-tests with themis 1.1.5 and still seeing a ton of fails. caveat: I'm about to board an airplane, wrote the harness in a hurry, might be my mistake. but: merge delayed until I'm sure.

gilesbowkett commented 9 years ago

all good, thx!