search

pandeiro / boot-http

A simple HTTP serve task for the Boot build tool
62 stars 34 forks source link

add option to set ip address or host #54

Open upgradingdave opened 7 years ago

upgradingdave commented 7 years ago

I saw a question on Slack about whether it's possible to set ip address that server binds to and so I threw this together quickly. This should work for jetty and http-kit. jetty uses the :host option and http-kit uses the :ip option. Feel free to merge if you think it'd be good option to provide. Otherwise, it might be better to take a step back and provide a more general way to pass options thru to the server impl (either to http-kit or jetty).

drownbes commented 7 years ago

@upgradingdave I have tried your fix and it is working. But there is Started Jetty on http://localhost:3000 in terminal instead of supported ip address.

upgradingdave commented 7 years ago

Hi @drownbes, glad to hear it's working. I updated so the output reflects the ip address configured. If you notice any other issue, please let me know. Thanks.