search

pandeiro / boot-http

A simple HTTP serve task for the Boot build tool
62 stars 34 forks source link

Fix #25 and fix #56 - shut down Jetty and nrepl on cleanup #59

Closed bhagany closed 7 years ago

bhagany commented 7 years ago

The silent parameter wasn't unquoted in the with-eval-in body, which resulted in an unknown symbol in the pod's environment. Similarly, the util namespace isn't loaded in the pod, so those symbols aren't known either. For whatever reason, both of these errors are swallowed somewhere in with-eval-in, which made this problem hard to diagnose, or even to see.

alandipert commented 7 years ago

@pandeiro :wave: this is a :100: :clap: :tumbler_glass: fix, any chance we could see it merged and deployed soon?

bhagany commented 7 years ago

that might be the best code review I've ever received

pandeiro commented 7 years ago

Wow, yes, thank you @alandipert for the ping and to @bhagany for the great sleuth work. Merging and cutting a new release pronto.