search

pandell / SlickGrid

A lightning fast JavaScript grid/spreadsheet
http://wiki.github.com/mleibman/SlickGrid
MIT License
1 stars 0 forks source link

Remove jQuery from DataView #5

Closed turnertime closed 9 years ago

turnertime commented 9 years ago
turnertime commented 9 years ago

Please note. I chose node.extend because I didn't want to rock the boat and instead have a library that is close to jQuery.extend. Also I only changed the modules that I needed to unit test web-grid.

turnertime commented 9 years ago

@pandell/core-developers Please review.

You can test this using web-grid : remove-integration branch.

milang commented 9 years ago

I like it, :+1: from me.

(@pandell/core-developers I recommend diffing with ignored whitespace to see actual changes).

jgoz commented 9 years ago

:+1: from me too.

timphillips commented 9 years ago

Nice change. :+1:

101100 commented 9 years ago

Looks good to me. :cookie:

Will this become a public npm package?

@milang Thanks for the tip RE: whitespace.

turnertime commented 9 years ago

@101100 No I think this will become 2.1.1-pandell.4 on npm.pandell registry.

turnertime commented 9 years ago

@pandell/core-developers Any objections to publishing as 2.1.1-pandell.4?

milang commented 9 years ago

Any objections to publishing as 2.1.1-pandell.4?

Fine by me (I assume we are already using exact dependency version spec).

turnertime commented 9 years ago

@milang Ok, I will release shortly. we are currently using ^2.1.1-pandell.3. Should we remove the ^ for the exact version?

jgoz commented 9 years ago

@turnertime

Should we remove the ^ for the exact version?

I could go either way. The only reason to drop the ^ and pin an exact version is if we plan to do breaking changes on the 2.1.1-pandell.X version, since we're not really following semver on this anyway.

milang commented 9 years ago

Should we remove the ^ for the exact version?

semver

Considering these are work-in-progress releases, I prefer the non-^ behaviour.