search

pandiaraj44 / react-native-datepicker-dialog

This library provides the cross-platform components for to open the date picker dialogs in effective way. It uses the native DatePickerAndroid & DatePickerIOS components. It will work for both ios & android.
MIT License
44 stars 15 forks source link

onCancel isn't being called on iOS #2

Closed diegocouto closed 7 years ago

diegocouto commented 7 years ago

Hi, guys!

First of all, congratulations for your great work! We've been using react-native-datepicker-dialog for a while without any problems.

Recently, we noticed that the onCancel handler works like a charm on Android, but it isn't being called on iOS.

Versions

pandiaraj44 commented 7 years ago

Hi, @diegocouto,

Thanks for using the library and reporting issues,

We will check it and let you know!

rahulnair25283 commented 7 years ago

Hi,

I have run into the same issue. onCancel isn't being called from iOS. I really like this library otherwise. It is really simple to use.

Versions: react-native: v0.43.3 react-native-dialog-picker: v0.0.4

rahulnair25283 commented 7 years ago

Hi,

I observed that in DatePickerDialog.ios.js, the cancel() function calls a cancel() function from this.props instead of calling the onCancel() function.

pandiaraj44 commented 7 years ago

Hi @rahulnair25283, You are right we have missed that one. Thanks for your contribution and fixed it. We will move this bug fixes and and some of new features on android datepicker mode selection.