pandoc-ext / diagram

Generate diagrams from embedded code; supports Mermaid, Dot/GraphViz, PlantUML, Asymptote, CeTZ, and TikZ.
MIT License
90 stars 11 forks source link

Breaking changes in quarto 1.4 #13

Closed fradav closed 1 month ago

fradav commented 11 months ago

Hi, quarto 1.4 changed the AST handling for figures in 1.4, so the actual pandoc.Figure code doesn’t work anymore for this release.

See https://quarto.org/docs/prerelease/1.4/lua_changes.html#support-for-crossreferenceable-elements-in-filters

Should we add a whole "if (quarto.version > 1.4)" code path for this? I’m still figuring out how to wrap the pandoc.Figure correctly now.

danmackinlay commented 8 months ago

Relevant information from quarto devs in this discussion

tarleb commented 1 month ago

The filter seems to work fine with Quarto 1.5, so I'm closing this. The only issue seems to be with filename attributes, for which I'll add a note to the README.