search

pandoc / lua-filters

A collection of lua filters for pandoc
MIT License
603 stars 165 forks source link

support graphviz #37

Closed muxueqz closed 5 years ago

muxueqz commented 5 years ago

Hi, i write a simple lua filter for Rendering graphviz Code inside a markdown file in a Image. I hope the code was good enough for this collection (my first pull request).

Thx @floriandd2ba

tarleb commented 5 years ago

Thank you, this is nice! There are a few things that should be done before we can merge this:

The code and docs seem to be very similar to what's in the plantuml filter. I'm not sure a separate filter is the best way; what do you think about merging this filter and the plantuml filter into a single graph-drawing filter?

floriandd2ba commented 5 years ago

Hi, for plantuml and graphviz are different tools necessary. Perhaps like this unix philosophy: Write programs that do one thing and do it well.

Just my 2 cent

Bye Florian

jgm commented 5 years ago

floriandd2ba notifications@github.com writes:

Write programs that do one thing and do it well.

The question is what counts as one thing. We have one 'cat' program, for example, instead of different ones for each file extension.

SommerEngineering commented 5 years ago

Dear @jgm and @muxueqz,

I can fix that too, along with my PR https://github.com/pandoc/lua-filters/pull/39. I do it as soon as possible.

muxueqz commented 5 years ago

@tarleb I add graphviz to apt list, but CI: Error: Unable to access jarfile /home/travis/plantuml.1.2018.9.jar

tarleb commented 5 years ago

Seems to have been a temporary connectivity problem. Re-running the tests fixed it.

tarleb commented 5 years ago

Closing in favor of #39. Thank your for contributing @muxueqz, you are credited for the graphviz part of that filter.