search

pandoc / lua-filters

A collection of lua filters for pandoc
MIT License
603 stars 165 forks source link

Added pandoc-quotes.lua. #57

Closed odkr closed 5 years ago

odkr commented 5 years ago

pandoc-quotes.lua replaces non-typographic quotation marks with typographic ones for languages other than US English.

tarleb commented 5 years ago

Thanks, this looks great and quite useful.

CI checks fail because access to the repo via git fails. While I like the idea of having a separate repo, it's worth noting that submodules have a couple of disadvantages. I'd prefer using git subtree instead.

Usage of the filter might become even easier if the YAML file was converted to a Lua table and integrated into the main script. Installation would be as simple as dropping the script in $/HOME/.pandoc/filters. But thanks to the good README, this is only a minor concern.

jgm commented 5 years ago

Both submodule and subtree should be avoided, I think.

odkr commented 5 years ago

Thanks! Also for the info about submodules. I wasn't aware of their disadvantages. I’ve made the changes you suggested and simplified the script.

tarleb commented 5 years ago

Thank you for this and for your patience! Merging now.