Closed deamme closed 5 years ago
I really love the overall design. It's super clean and gives an easy way to get all the repo addresses.
Regarding the click behavior we are kinda blocked for now. Ideally clicking a repo should re-route you to the related repo frontend. This should be handled at the
wrapper
level though because of theiframe
based sandboxing solution. And this is not yet handled by thearagonAPI.
Maybe we could ask @0x6431346e if this feature could be added at some point ?
Otherwise my main concern regarding this PR is the choice to ditch the observable and fetch all data from the main
background
script because this prevents to reflect repo's name or description updates, right ?
Uhm, I think so... there is a discussion here about letting apps know about other apps. And the "router" functionality will be implemented in the Notifications panel (when you click a notification it will redirect you to it's app) so I believe it makes sense to move it to the aragonAPI. But, making apps talk with each other, isn't it pretty much another way of solving the "monolithic" apps problem that Autark is tackling? 🤔
Thanks for the answer @0x6431346e!
Yeah there is some ongoing long-term work on monolithic apps. We're just trying it figure out how to make things work in the meanwhile ;)
The navigation API would be perfect: for instance to redirect to the relevant vote from within another app, etc.
Preview
Fixes #26
We need to update
@pando/repository/contracts/PandoRepository.sol
in order for this to work.One thing that has not been addressed yet is the click action when you click on a specific repo on the list. What should happen and how should we handle that? Since we don't have control over the wrapper - we can't redirect to a different URL.
Cheers!