search

pandorabox-io / in-game

Random code and stuff for in-game things
MIT License
3 stars 0 forks source link

Remove griefable shops from server #215

Open Klaranth opened 2 years ago

Klaranth commented 2 years ago

chuche952 ; SX

At 7346,23240 in hifi city, it is stated that several shops are not secure and can be griefed. Then it makes sense to remove them, or at least make them uncraftable until they are fixed. Or remove the sign, if its wrong.

I'm not sure if I fully understood problem but if there's protection problems with some nodes then reports would be better for that. Or is it about some unprotected shops at HiFi city?

I mean protection problems are usually fixed very soon after reported and verified, some shops are not used that much and if there's protection problems with those then probably reason why it is not already fixed is simply because nobody reported it yet.

Please see at HiFi city, its reported there that those shops are not secure.

Well then sounds like some testing is needed before doing anything else, luckily most players use well tested fancy vendors or smartshops.

S-S-X commented 2 years ago

https://pandorabox.io/map/#!/map/0/11/7346/23240

OgelGames commented 2 years ago

The HiFi city marketplace is not meant to be fully protected; smartshops, fancy vendors and travelnets are self-protected, and are perfectly secure there.

S-S-X commented 2 years ago

The HiFi city marketplace is not meant to be fully protected; smartshops, fancy vendors and travelnets are self-protected, and are perfectly secure there.

Have you tested other available shops for protection? I'm not really sure but my impression was that this is not about fancy vendors or smart shops but about protection problems with some other shop.

Pandorabox has multiple mods that provide those, not just fancy vendors and smart shops.

OgelGames commented 2 years ago

I think the only other shop node is easyvend, and that should be protected too (though I've never tested it): https://github.com/minetest-mirrors/easyvend/blob/74dc29002186f87a531c64bb9e325388640af596/easyvend.lua#L964-L991

S-S-X commented 2 years ago

Okay, I've switched labels to be in-game task.

To do:

  1. Determine if there's protection issues.
    • If protection is fine: Remove public marketplace signs.
    • If protection is not fine: Remove public marketplace signs, open bug report.
  2. Close this issue.

Signs telling about issues with shops should be near linked map location, I've not checked these myself so no idea what there is. Also I do not know if someone already removed or changed those signs.