pandorabox-io / pandorabox.io

Pandorabox infrastructure code
https://pandorabox.io
31 stars 4 forks source link

Add recipe to make black dye from charcoal #291

Closed OgelGames closed 5 years ago

OgelGames commented 5 years ago

Currently there are only two ways to get black dye; coal (which cannot be created), and black tulips (which can be created, but only very inefficiently).

With demand for black dye so high (mainly for making silver sandstone), it would make sense to add some way of producing it that matches the production of white dye (from bone generators).

So I would propose to add a way of making black dye from charcoal, such as 1 dye being extracted from 4 charcoal.

Please let me know what you think, an I will add the appropriate recipe if you think it's ok.

thomasrudin commented 5 years ago

I think that sounds fair (i may be biased though :smile:) The quantity could be higher:

I need to add some recipes for dyes too: some flowers aren't available as an extractor recipe, but i'll do that myself when i have time..

OgelGames commented 5 years ago

The quantity could be higher:

  • 1 black dye from 1 charcoal (if crafted)
  • 2 black dye from 1 charcoal (if extracted)

Maybe, but with the fact that currently you can get 16 charcoal from a single tree node (and some trees like oak yielding a few thousand nodes), I feel it would lead to an oversupply if the amount of dye produced is too high...

thomasrudin commented 5 years ago

Oh, right. And because of the changed recipe (https://github.com/pandorabox-io/pandorabox_custom/blob/master/recipes.lua#L21 wood instead of tree) that makes it even worse...

Alternatively the yield of the charcoal recipe could be changed from 4 to 1

But yeah, your proposal makes sense now...

OgelGames commented 5 years ago

Alternatively the yield of the charcoal recipe could be changed from 4 to 1

No, I don't think that should change, as it nicely matches the quantity of sticks that can be made, which are of course used to make torches.

I think the quantity of dye could be increased a bit though, as I just did some rough calculations on what could be created from one default tree, and it can actually make a lot more white dye than I first though.

So the recipes could be adjusted to produce 1 black dye from 2 charcoal when crafted, and 1 black dye from 1 charcoal when extracted. (though imo the crafting recipe isn't needed, unless it's added for bones as well)

OgelGames commented 5 years ago

When will this be added to the server?

thomasrudin commented 5 years ago

When will this be added to the server?

This was already in there, just the recipe for "plain" crafting was missing: https://github.com/pandorabox-io/pandorabox_custom/commit/d92cb5a7d602169b12b523c6832e7b7e14fa5498

By the way: we have a "continuous delivery" pipeline now for the mods. If the mod gets upgraded in the pandorabox-mods repo it gets updated on the server automatically... (https://github.com/pandorabox-io/pandorabox-mods/issues/3)

OgelGames commented 5 years ago

Oh, nice, must be a bug in the crafting guide then, because extracting dye still isn't showing as a use for charcoal... (even though it works)

thomasrudin commented 5 years ago

I need to retest this then :/

SwissalpS commented 5 years ago

I was able to craft black dye from nine charcoal.

thomasrudin commented 5 years ago

Worked for me too, closing...