search

pandorabox-io / pandorabox.io

Pandorabox infrastructure code
https://pandorabox.io
31 stars 4 forks source link

smartshop/mail crash #542

Closed OgelGames closed 4 years ago

OgelGames commented 4 years ago 
2020-09-19 01:56:51: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'smartshop' in callback on_playerReceiveFields(): /data/world//worldmods/mail_mod/api.lua:54: attempt to concatenate field 'to' (a nil value)
2020-09-19 01:56:51: ERROR[Main]: stack traceback:
2020-09-19 01:56:51: ERROR[Main]:   /data/world//worldmods/mail_mod/api.lua:54: in function 'send'
2020-09-19 01:56:51: ERROR[Main]:   /data/world//worldmods/smartshop/init.lua:106: in function 'send_mail'
2020-09-19 01:56:51: ERROR[Main]:   /data/world//worldmods/smartshop/init.lua:178: in function 'receive_fields'
2020-09-19 01:56:51: ERROR[Main]:   /data/world//worldmods/smartshop/init.lua:198: in function 'func'
2020-09-19 01:56:51: ERROR[Main]:   ...ocal/share/minetest/builtin/profiler/instrumentation.lua:106: in function <...ocal/share/minetest/builtin/profiler/instrumentation.lua:100>
2020-09-19 01:56:51: ERROR[Main]:   /usr/local/share/minetest/builtin/game/register.lua:429: in function </usr/local/share/minetest/builtin/game/register.lua:413>

From chat log:

<ElSmacko> Well that was odd...
<bass> lol, ElSmacko just bought his own glider for 0 dollarts
<cyriax> Yeah, the server restarted.
<Huhhila> hrm, smartshop mail notification?
<bass> lmao
<RedstonePro4563> nobody is at spawn
<Huhhila> wonder whose smartshop was that...
<ElSmacko> I guess buying from your own smartshop can crash the game?
<bass> ElSmacko's hackin'
<cyriax> I'd say try to reproduce it?
<bass> nooo
<Huhhila> I'd say use test.pandorabox.io for reproduction attempts
<cyriax> That's even better...
<ElSmacko> Ok, I'll go switch over and test. See if buying other things crashes it...
ElSmacko left the game
...
Player ElSmacko joined the game
<ElSmacko> Lol, I guess buying any damaged tool from a smart shop crashes the server...
...
<ElSmacko> Did more testing of smart shops, seems buying the last of any items from a smart shop triggers the crash.

I think this is probably related to the recent mail mod changes: https://github.com/pandorabox-io/pandorabox-mods/pull/945

BuckarooBanzay commented 4 years ago

I think this is probably related to the recent mail mod changes: pandorabox-io/pandorabox-mods#945

Yes, there was a rather big PR from https://github.com/PeterNerlich which introduced cc/bcc and contacts. I haven't tested that thorough it seems... :yum: