pandorabox-io / pandorabox_custom

pandorabox server customization mod
https://pandorabox.io
MIT License
4 stars 7 forks source link

add gravel-stonebrick #33

Open BuckarooBanzay opened 3 years ago

BuckarooBanzay commented 3 years ago

This PR adds a half-gravel, half-stonebrick node with support for the table-saw

@wsor4035

could we get a node that is gravel on top and a solid base on bottem like linux forks has? also, ability to slice it into 3 piece slopes to match the track slope
https://git.bananach.space/moreblocks.git/tree/nodes.lua#n634

screenshot_20210213_114027

TODO

Stats

OgelGames commented 3 years ago

recipe for moreblocks:gravel_stonebrick

minetest.register_craft({
output = "moreblocks:gravel_stonebrick 4",
recipe = {
{"default:gravel", "default:gravel"},
{"default:stonebrick", "default:stonebrick"},
}
})
wsor4035 commented 3 years ago

see comments in the pandora box discord

S-S-X commented 3 years ago

Tested, works 👍

Did you test if these block trains on slopes? I think there's some group or property to not block trains...

OgelGames commented 3 years ago

Did you test if these block trains on slopes? I think there's some group or property to not block trains...

No, but I don't think they would, and if there's any issues it can easily be added later.

S-S-X commented 3 years ago

Did you test if these block trains on slopes? I think there's some group or property to not block trains...

No, but I don't think they would, and if there's any issues it can easily be added later.

I had exact opposite expectation: I think they would, reason for asking for test. So tested and these gravel slopes will block trains in slopes just like all other slopes.

edit. checked what was needed and it is group not_blocking_trains

Could be added directly to full node, tested that. However only some of these nodes actually should be non blocking, not all. Maybe stairplus has something in API for this?

OgelGames commented 3 years ago

gravel slopes will block trains in slopes just like all other slopes

Ah, I thought the other slopes didn't block trains...

Probably the easiest way would be to override stairsplus:prepare_groups and add the extra group in there. https://github.com/minetest-mods/moreblocks/blob/master/stairsplus/init.lua#L24

EDIT: actually that might not be possible because of mod load order... 🤔

Montandalar commented 2 years ago

LinuxForks' moreblocks has a set of gravel train helper blocks that they use: Gravel stonebrick, gravel slope, slope 2a, 2b, 3a, 3b and 3c. These match the texture of the slope block properly and have not_blocking_trains on them.

linuxforks_moreblocks_gravelstuff

I don't think the whole gamut of circular saw shapes is actually helpful, so I would rather just port the LinuxForks shaps over to pandorabox_custom than faff around with stairsplus/moreblocks which clearly has problems. I can prepare a PR if you want.

S-S-X commented 2 years ago

I don't think the whole gamut of circular saw shapes is actually helpful

I do think a lot of those would be very good, already many times and with many nodes I wanted to have this feature to allow building railways to existing areas.

At least: stone tiles, tar blocks, most scifi nodes, most tree trunks and planks and of course gravel.

edit to clarify: just group support would be good for most, not necessarily actual rail nodes. for gravel however it would be nice to have actual rail nodes that also are walkable instead of those that completely skips collisions. (does advtrain have problem with that? why "default" gravel slopes are not walkable?)